Fix 2D viewport scrollbar contrast in modern theme #112296
Draft
+14
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This introduces a quirk in both themes that now you can click between the scrollbar and the viewport margin, and that triggers a selection instead. It's nothing major, but something to keep in mind. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the issue of poor visibility of scrollbars in the 2D viewport in the modern theme:
Modern theme uses styleboxes for scrollbars unlike classic theme that used images with transparent pixels. Until #111975 there was no way to add space between ScrollContainer content and its scrollbar without either using images with transparent pixels or relying on border hack which only worked with opaque colors, which made them look broken in the 2D viewport. This PR uses #111975 to remove the hack and make scrollbars semitransparent.
Note that although it's now possible to add inner scrollbar margins to scroll containers, I still had to add outer margins to the 2D viewport to separate them from the viewport edges, like it's done for all viewport overlays. This has a side effect of slightly larger margins in the classic theme due to transparent pixels in them:
If necessary the scrollbars in the classic theme can also be updated later to not rely on images while keeping their look.